Horton

Re: Why does TupleDescInitBuiltinEntry lack a "default: error" case?

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2018-12-09T20:04:53Z
Lists: pgsql-hackers 
Hi,

On 2018-12-09 14:49:35 -0500, Tom Lane wrote:
> If the passed-in type OID isn't one of the very short list that
> TupleDescInitBuiltinEntry supports, it will silently hand back
> a broken TupleDesc, rather than throwing an error.  How can
> this possibly be considered good code?

+1

Greetings,

Andres Freund

Commits

  1. Make TupleDescInitBuiltinEntry throw error for unsupported types.