Re: Too-short timeouts in test code

On Sat, Dec 08, 2018 at 04:16:01PM -0800, Noah Misch wrote:
> The 180s timeout in poll_query_until has been trouble-free since 2a0f89c
> introduced it two years ago.  I plan to raise the timeouts in question to
> 180s, as attached.

That's annoying, thanks for tracking those down.

> @@ -72,7 +72,7 @@ my $endpos = $node_master->safe_psql('postgres',
>  print "waiting to replay $endpos\n";
>  
>  my $stdout_recv = $node_master->pg_recvlogical_upto(
> -	'postgres', 'test_slot', $endpos, 10,
> +	'postgres', 'test_slot', $endpos, 180,
>  	'include-xids'     => '0',
>  	'skip-empty-xacts' => '1');

Instead of allowing callers of pg_recvlogical_upto() to define the
timeout they want, perhaps it would be better to hardcode the timeout
limit within the routine?
--
Michael