Re: pg_partition_tree crashes for a non-defined relation

On Sat, Dec 08, 2018 at 08:46:08AM -0500, Stephen Frost wrote:
> We should really have a more clearly defined policy around this, but my
> recollection is that we often prefer to return NULL rather than throwing
> an error for the convenience of people doing things like querying
> pg_class using similar functions.

Yes, that's visibly right.  At least that's what I can see from the
various pg_get_*def and pg_*_is_visible.  Returning NULL would indeed
be more consistent.

> I wonder if we maybe should have a regression test for every such
> function which just queries the catalog in a way to force the function
> to be called for every relation defined in the regression tests, to
> ensure that it doesn't segfault or throw an error..

Like sqlsmith?  It looks hard to me to make something like that part of
the main regression test suite, as that's going to be costly and hard to
scale with.
--
Michael