Horton

Thread

Commits

  1. Rewrite ExecPartitionCheckEmitError for clarity

  1. rewrite ExecPartitionCheckEmitError

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2018-12-06T22:22:21Z

    Just on cleanliness grounds, I propose to rewrite the function in
$SUBJECT.  I came across this while reviewing some already-committed
patch for partition pruning, and it's been sitting in my laptop ever
since.

I think the current coding is too convoluted and hard to follow.  The
patch makes it much simpler (IMO).

-- 
Álvaro Herrera

  2. Re: rewrite ExecPartitionCheckEmitError

    Robert Haas <robertmhaas@gmail.com> — 2018-12-07T20:32:32Z

    On Thu, Dec 6, 2018 at 5:22 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> Just on cleanliness grounds, I propose to rewrite the function in
> $SUBJECT.  I came across this while reviewing some already-committed
> patch for partition pruning, and it's been sitting in my laptop ever
> since.
>
> I think the current coding is too convoluted and hard to follow.  The
> patch makes it much simpler (IMO).

I don't really think this is an improvement, but the only part I
really dislike is s/val_desc/valdsc/.  That is surely not an
improvement in readability.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

  3. Re: rewrite ExecPartitionCheckEmitError

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2018-12-28T17:52:24Z

    On 2018-Dec-07, Robert Haas wrote:

> On Thu, Dec 6, 2018 at 5:22 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > Just on cleanliness grounds, I propose to rewrite the function in
> > $SUBJECT.  I came across this while reviewing some already-committed
> > patch for partition pruning, and it's been sitting in my laptop ever
> > since.
> >
> > I think the current coding is too convoluted and hard to follow.  The
> > patch makes it much simpler (IMO).
> 
> I don't really think this is an improvement, but the only part I
> really dislike is s/val_desc/valdsc/.  That is surely not an
> improvement in readability.

Point taken; pushed with that change.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  4. Re: rewrite ExecPartitionCheckEmitError

    David Rowley <david.rowley@2ndquadrant.com> — 2019-01-01T02:57:37Z

    On Sat, 29 Dec 2018 at 06:52, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> Point taken; pushed with that change.

Marking this as committed in the CF app.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services