Horton

Re: error message when subscription target is a partitioned table

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Magnus Hagander <magnus@hagander.net>, Tatsuo Ishii <ishii@sraoss.co.jp>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-12-06T04:19:26Z
Lists: pgsql-hackers 
On Thu, Dec 06, 2018 at 11:34:19AM +0900, Amit Langote wrote:
> Adding to January CF.

Okay, that looks good to me based on your arguments upthread.  A
small-ish comment I have is that you could use a set of if/else if
conditions instead of separate ifs.
--
Michael

Commits

  1. Improve error messages for incorrect types of logical replication targets