Horton

Re: Use durable_unlink for .ready and .done files for WAL segment removal

Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>

View thread View on postgr.es
From: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
To: bossartn@amazon.com
Cc: michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Date: 2018-12-06T04:55:46Z
Lists: pgsql-hackers 
Hello.

At Wed, 5 Dec 2018 16:11:23 +0000, "Bossart, Nathan" <bossartn@amazon.com> wrote in <DB47EBD7-7291-4C39-9F8F-BE42E5193BD5@amazon.com>
> The v4 patch looks good to me!

durable_unlnk has two modes of faiure. Failure to unlink and
fsync. If once it fails at the fsync stage, subsequent
durable_unlink calls for the same file always fail to unlink with
ENOENT.  If durable_unlink is intended to be called repeatedly on
falure, perhaps it should return a different code for each
failure so that the caller can indentify what to do next.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Ensure cleanup of orphan archive status files