Horton

Re: Typo in description of replay_lag attribute in pg_stat_replication view

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Maksim Milyutin <milyutinma@gmail.com>
Cc: pgsql-docs@lists.postgresql.org
Date: 2018-12-04T00:18:02Z
Lists: pgsql-docs 
On Mon, Dec 03, 2018 at 06:18:30PM +0300, Maksim Milyutin wrote:
> I have noticed that in description of *flush_lag* in pg_stat_replication
> view (https://www.postgresql.org/docs/current/monitoring-stats.html#PG-STAT-REPLICATION-VIEW)
> there exists unknown value of synchronous_commit parameter - *remote_flush*.
> I think it was meant to use the value *on*.

Yes, you are right.  It should be "on" as "remote_flush" is not a valid
value.  remote_flush is listed in SyncCommitLevel though, so this makes
me wonder if we should also introduce a new value for this purpose
available for users.  The fix you propose looks good to me.  Any
opinions from others?
--
Michael

Commits

  1. Fix invalid value of synchronous_commit in description of flush_lag