Re: Add extension options to control TAP and isolation tests

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Nikolay Shaplov <dhyan@nataraj.su>
Cc: pgsql-hackers@lists.postgresql.org, Adam Berlin <berlin.ab@gmail.com>
Date: 2018-11-29T02:00:11Z
Lists: pgsql-hackers

Attachments

On Fri, Nov 23, 2018 at 09:43:45AM +0900, Michael Paquier wrote:
> That's for the main regression test suite within src/test/regress, TAP
> is also a regression test suite, the page of the link reflects the
> general set of test suites available.

The main patch had to be reverted a couple of days ago via 1d7dd18, and
I have been digging and fixing the set of issues the buildfarm has been
complaining about since.  There were two problems:
- MSVC scripts were not able to handle modules with NO_INSTALLCHECK
defined, and vcregress.pl runs with the assumption that installcheck is
used.  Support for that has been added in 431f159.  Some modules have
been also lacking NO_INSTALLCHECK.
- contrib/bloom/ are unstable.  I have not spent time investigating the
actual root issue, but spawned a thread with the authors of the tests:
https://www.postgresql.org/message-id/20181126025125.GH1776@paquier.xyz

I am attaching the patch I would like to commit to close this thread,
which has as single change TAP_TESTS commented out in contrib/bloom/ to
not explode the buildfarm.  Any objections to that?
--
Michael

Commits

  1. Add PGXS options to control TAP and isolation tests, take two

  2. Add PGXS options to control TAP and isolation tests