Re: Constraint documentation
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: David Fetter <david@fetter.org>
Cc: Patrick Francelle <patrick@francelle.name>, Tom Lane <tgl@sss.pgh.pa.us>, Fabien COELHO <coelho@cri.ensmp.fr>, "David G. Johnston" <david.g.johnston@gmail.com>, Pantelis Theodosiou <ypercube@gmail.com>, Lætitia Avrot <laetitia.avrot@gmail.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Brad DeJong <bpd0018@gmail.com>, Vik Fearing <vik.fearing@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-11-26T15:43:20Z
Lists: pgsql-hackers
I have pushed this. On 2018-Nov-26, David Fetter wrote: > On Thu, Nov 22, 2018 at 03:16:11PM +0100, Patrick Francelle wrote: > > > To address your remark, I added a small message in the CREATE TABLE > > reference page to be more explicit about the topic, so that it would be > > a warning for the users reading the section. And then a reference to the > > CHECK constraint page where the full explanation is to be located. > > > > That way, the caveat is mentioned in both pages, but the full > > explanation is located only on a single page. That was a good idea, but your third sentence repeated what was being said in the first sentence in the same paragraph. I edited that to put the cross-reference next to the first sentence instead. > I believe that features F671 (subqueries in CHECK constraints) and > possibly F673 (reads SQL-data routine invocations in CHECK > constraints) from the standard should be referred to here. > > We haven't implemented either one of them, but we might some day. I don't necessarily disagree, but I don't think we put many feature references in the docs. I suppose we can edit it when we implement F671 and F673. Or maybe you want to submit a followup patch. It didn't seem worth blocking this patch for your proposed change (particularly since Lætitia seems to have given up on it already). Thanks, -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Clarify that cross-row constraints are unsupported
- 36d442a25a1a 12.0 landed