Thread

Commits

  1. Silence compiler warnings

  1. prewarm compiler warnings

    Erik Rijkers <er@xs4all.nl> — 2018-11-23T15:34:29Z

    gcc-6.3.0 complains about this:
    
    autoprewarm.c: In function ‘autoprewarm_main’:
    autoprewarm.c:210:9: warning: variable ‘rc’ set but not used 
    [-Wunused-but-set-variable]
        int   rc;
    
    The warning comes only in master.
    
    The warnings are a bit annoying; the attached silences them by removing 
    those assignments.
    
    Thanks,
    
    Erik Rijkers
    
    
    
  2. Re: prewarm compiler warnings

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2018-11-23T16:08:11Z

    On 2018-Nov-23, Erik Rijkers wrote:
    
    > gcc-6.3.0 complains about this:
    > 
    > autoprewarm.c: In function ‘autoprewarm_main’:
    > autoprewarm.c:210:9: warning: variable ‘rc’ set but not used
    > [-Wunused-but-set-variable]
    >    int   rc;
    > 
    > The warning comes only in master.
    
    Yeah, it's fairly new.  I noticed a couple of other places that could
    use the same adjustment and pushed them all together.  (I used a cast to
    void as all other places do that, which appeases Coverity about the
    discrepancy.)
    
    -- 
    Álvaro Herrera                https://www.2ndQuadrant.com/
    PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services