Re: Support custom socket directory in pg_upgrade

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2018-11-23T14:07:12Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add a --socketdir option to pg_upgrade.
- 2d34ad843031 12.0 landed

On 2018-Nov-12, Tom Lane wrote:

> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> > On 12/11/2018 20:00, Tom Lane wrote:
> >> Also, even if we had an arguably-better idea, I suspect that there would
> >> always be cases where it didn't work.  For example, one idea is to make
> >> a temporary directory under the installation's normal socket directory
> >> (thus, /tmp/pgXXXX/ or some such).  But, if the normal socket directory
> >> is not /tmp, we might find that pg_upgrade can't write there.
> 
> > We do exactly that in pg_regress and it's never been a problem.
> 
> Yeah, but pg_upgrade is used by a much wider variety of people
> than pg_regress.

Surely they can just set TMPDIR if /tmp is not writable?  If TMPDIR is
set and not writable, bark at the user for it.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services