Horton

Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.

Christoph Berg <myon@debian.org>

View thread View on postgr.es
From: Christoph Berg <myon@debian.org>
To: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2018-11-21T08:20:43Z
Lists: pgsql-hackers 
Re: Andres Freund 2018-11-21 <E1gPG3j-0003cy-03@gemulon.postgresql.org>
> The biggest user of WITH OID columns was postgres' catalog. This
> commit changes all 'magic' oid columns to be columns that are normally
> declared and stored.

postgres=# \d+ pg_class
[...]
Indexe:
    "pg_class_oid_index" UNIQUE, btree (oid)

Now that oid is a proper column, shouldn't that be a PRIMARY KEY?
(Just for the looks.)

Christoph

Commits

  1. Remove line duplicated during conflict resolution.

  2. Re-add default_with_oids GUC to avoid breaking old dump files.

  3. Remove WITH OIDS support, change oid catalog column visibility.