Horton

Re: [PATCH] XLogReadRecord returns pointer to currently read page

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, hlinnaka@iki.fi, pgsql-hackers@postgresql.org
Date: 2018-11-20T23:50:28Z
Lists: pgsql-hackers 
On Tue, Nov 20, 2018 at 06:37:36AM +0500, Andrey Lepikhov wrote:
> On 20.11.2018 6:30, Michael Paquier wrote:
>> Yeah, this one is not entirely true now.  What about the following
>> instead:
>> -   /* Buffer for current ReadRecord result (expandable) */
>> +   /*
>> +    * Buffer for current ReadRecord result (expandable), used when a record
>> +    * crosses a page boundary.
>> +    */
> 
> I agree

Okay, I have committed this version, after checking that there were no
other spots.
--
Michael

Commits

  1. Improve description of buffer used to store records in WAL reader

  2. Remove unnecessary memcpy when reading WAL record fitting on page