Horton

Re: Accounting of zero-filled buffers in EXPLAIN (BUFFERS)

Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>

View thread View on postgr.es
From: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
To: alvherre@2ndquadrant.com
Cc: david.rowley@2ndquadrant.com, kommi.haribabu@gmail.com, thomas.munro@enterprisedb.com, andres@anarazel.de, pgsql-hackers@postgresql.org
Date: 2018-11-19T04:24:08Z
Lists: pgsql-hackers 
At Sat, 17 Nov 2018 11:15:54 -0300, Alvaro Herrera <alvherre@2ndquadrant.com> wrote in <20181117141554.4dkx2u4j6md3bqdh@alvherre.pgsql>
> Is this patch committable now?

I don't think so. We should make a decision on a point.

I was a bit confused (sorry) but IIUIC Haribabu suggested that
the RBM_ZERO_ON_ERROR case should be included to read (not just
ignored). I'm on it.  I think that RPM_ZERO_* other than ON_ERROR
cases could be a kind of hit but I don't insist on it.

So, I think we should decide on at least the ON_ERROR case before
this becomes commttable.

The another counter could be another issue. I don't object to add
the counter but I'm not sure what is the suitable name.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Don't count zero-filled buffers as 'read' in EXPLAIN.