Horton

Re: fix psql \conninfo & \connect when using hostaddr

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Arthur Zakirov <a.zakirov@postgrespro.ru>, Robert Haas <robertmhaas@gmail.com>
Date: 2018-11-17T14:56:37Z
Lists: pgsql-hackers 
On 2018-Nov-17, Fabien COELHO wrote:

> 
> > > Fabien, are you planning to fix things per Arthur's review?
> > 
> > Yep, I am.
> > 
> > I will not do the above though, because the PQgetHostaddr API would
> > differ from all other connection status functions (PQgetHost,
> > PQgetUser...) which are all "char * PQget<Something>(PGconn * conn)"
> 
> Sorry, I'm mixing everything, the function is an internal one.

Yeah :-)

> I'm working on improving the patch.

Cool.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Tweak libpq's PQhost, PQhostaddr, and psql's \connect

  2. psql: Show IP address in \conninfo