Re: ATTACH/DETACH PARTITION CONCURRENTLY

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, David Rowley <david.rowley@2ndquadrant.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Simon Riggs <simon@2ndquadrant.com>

Date: 2018-11-17T00:06:43Z

Lists: pgsql-hackers

On Fri, Nov 16, 2018 at 09:38:40AM -0500, Robert Haas wrote:
> OK, but it seems to me that your version of my patch rearranges the
> code more than necessary.
> 
> How about the attached?

What you are proposing here looks good to me.  Thanks!
--
Michael

Commits

Allow ATTACH PARTITION with only ShareUpdateExclusiveLock.
- 898e5e3290a7 12.0 landed
Change lock acquisition order in expand_inherited_rtentry.
- f4b6341d5fcb 12.0 landed
Move code for managing PartitionDescs into a new file, partdesc.c
- 1bb5e7821810 12.0 landed
Remove more redundant relation locking during executor startup.
- f2343653f5b2 12.0 cited
Add assertions that we hold some relevant lock during relation open.
- b04aeb0a053e 12.0 cited
Try to acquire relation locks in RangeVarGetRelid.
- 4240e429d0c2 9.2.0 cited