Re: move PartitionBoundInfo creation code
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-11-13T13:59:15Z
Lists: pgsql-hackers
On 2018-Nov-13, Michael Paquier wrote: > On Tue, Nov 13, 2018 at 09:58:08AM -0300, Alvaro Herrera wrote: > > "the context that was active when the function was called" is typically > > expressed simply as "the current memory context". Perhaps the whole > > phrase can be reduced to "The object returned by this function is wholly > > allocated in the current memory context"? > > Yes, that looks cleaner. I am planning to do a last lookup round on > tomorrow morning my time before committing, so I may still tweak a > couple of other words... Cool. I gave the patch a read and it looks reasonable to me. Memory management in RelationBuildPartitionDesc is crummy, but I don't think it's this patch's fault. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Refactor code creating PartitionBoundInfo
- b52b7dc250bb 12.0 landed