Re: Make description of heap records more talkative for flags

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, bossartn@amazon.com
Date: 2018-11-10T00:11:21Z
Lists: pgsql-hackers

Attachments

On Fri, Nov 09, 2018 at 04:23:57PM +0100, Dmitry Dolgov wrote:
> This thread is being inactive for quite some time. As far as I understand, the
> agreement was to add it in the PG12 commit cycle, so probably it's a good time
> to do so. Any plans about that?

This thread needed a new patch to answer to the previous comment from
Nathan, and it was not marked as waiting on author.  Sorry I got
confused with the CF status and I have missed Nathan's update, which
mentions a good idea.  So attached is an updated patch which adds "0x"
in front of each flag output.

I have committed the fix for the incorrect routine name in xlog_heapam.h
separately.
--
Michael

Commits

  1. Add flag values in WAL description to all heap records

  2. Fix incorrect routine name in xlog_heapam.h