Re: fix psql \conninfo & \connect when using hostaddr
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Arthur Zakirov <a.zakirov@postgrespro.ru>, Pavel Stehule <pavel.stehule@gmail.com>, Fabien COELHO <coelho@cri.ensmp.fr>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Date: 2018-11-09T01:14:14Z
Lists: pgsql-hackers
On Thu, Nov 08, 2018 at 12:13:31PM -0300, Alvaro Herrera wrote: > On 2018-Nov-08, Tom Lane wrote: >> Visually, however, I think this is better off with braces because >> it *looks* like a multi-line if-block. The braces also make it >> clear that your intent was not, say, >> >> while (some-mutable-condition) >> /* skip */ ; >> do_something_else(); > > Right, that too. Fortunately I think compilers warn about mismatching > indentation nowadays, at least in some cases. I don't recall seeing a compiler warning about that, but I do recall coverity complaining loudly about such things. It is better style to use braces if there is one line of code with a comment block in my opinion. And there is no need for braces if there is no comment. -- Michael
Commits
-
Tweak libpq's PQhost, PQhostaddr, and psql's \connect
- 313f56ce2d1b 12.0 landed
-
psql: Show IP address in \conninfo
- 6e5f8d489acc 12.0 landed