Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Amit Langote <amitlangote09@gmail.com>
Date: 2018-11-08T15:51:54Z
Lists: pgsql-bugs, pgsql-hackers
On 2018-Nov-07, Amit Langote wrote: > I think the result in this case should be an error, just as it would in > the regular inheritance case. > > create table parent (a text); > create table child (a text collate "en_US") inherits (parent); > NOTICE: merging column "a" with inherited definition > ERROR: column "a" has a collation conflict > DETAIL: "default" versus "en_US" > > In fact, I see that ATTACH PARTITION rejects a partition if collations > don't match. Hmm, I'm thinking perhaps we shouldn't backpatch this part. It's obviously a bug, but we might break somebody's working apps. Therefore I think I'd rather leave it out of the current bugfix and commit separately. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Revise attribute handling code on partition creation
- e0c05bf4a7e6 11.2 landed
- 705d433fd5e2 12.0 landed
- 21c9e4973cec 10.7 landed