Horton

Re: New Defects reported by Coverity Scan for PostgreSQL

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Emre Hasegeli <emre@hasegeli.com>
Cc: tgl@sss.pgh.pa.us, tomas.vondra@2ndquadrant.com, nyu@pivotal.io, pgsql-hackers@postgresql.org
Date: 2018-11-06T17:32:10Z
Lists: pgsql-hackers

Attachments

On 2018-Nov-06, Emre Hasegeli wrote:

> The patch is attached to improve the comments and variable names.  I
> explained the functions with the same signature on the file header.  I
> can duplicate those on the function headers if you find that better.

Surely the comment in line 3839 deserves an update :-)

This seems good material.  I would put the detailed conventions comment 
separately from the head of the file, like this (where I also changed
"Type1 *type1" into "Type1 *obj1", and a few "has" to "have")

Thanks

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. geo_ops.c: Clarify comments and function arguments

  2. Refactor geometric functions and operators