Horton

Re: [RFC] Removing "magic" oids

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-10-27T18:56:56Z
Lists: pgsql-hackers 
Hi,

On 2018-10-28 00:21:23 +0530, Amit Kapila wrote:
> On Sun, Sep 30, 2018 at 9:18 AM Andres Freund <andres@anarazel.de> wrote:
> > I think we should drop WITH OIDs support.  pg_dump should convert WITH
> > OIDs tables into tables that have an explicit oid column (with an
> > appropriate default function), pg_upgrade should refuse to upgrade them.
> >
> 
> Is there any technical reason why you think pg_upgrade should refuse
> to upgrade them?  I think there is an argument to break backward
> compatibility here and many people on the thread seem to be okay with
> that, but refusing to upgrade sounds more restrictive.

They'd not be on-disk compatible, because the column isn't stored as a
normal column but in the t_hoff space.

Greetings,

Andres Freund

Commits

  1. Revive test of concurrent OID generation.

  2. Fix typo introduced in 578b229718.

  3. Fix pg_upgrade for oid removal.

  4. Fix sepgsql compile error caused by oid removal.

  5. Remove WITH OIDS support, change oid catalog column visibility.