Horton

Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, David Fetter <david@fetter.org>, pgsql-hackers@postgresql.org
Date: 2018-10-26T12:08:13Z
Lists: pgsql-hackers 
On Fri, Oct 26, 2018 at 11:15:19AM +0100, Dagfinn Ilmari Mannsåker wrote:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> The committed patches look sane to me, but should we back-patch into 11?
>> This isn't quite a bug fix maybe, but it's inconsistent if v11 server &
>> docs recommend this syntax while v11 psql doesn't produce it.
> 
> I was going to suggest backpatching it, as I consider it a bug in the
> original implementation, if not critical.  Making it harder for people
> to use the recommended syntax than the deprecated one is not nice.

I didn't think that this was much of a big deal as the deprecated
grammar is still supported on v11, but as both of you think in this
sense I am fine to patch REL_11_STABLE as well.  Please just wait a
bit...
--
Michael

Commits

  1. Add tab completion of EXECUTE FUNCTION for CREATE TRIGGER in psql

  2. Improve tab completion of CREATE EVENT TRIGGER in psql

  3. Improve tab completion for ANALYZE, EXPLAIN, and VACUUM.