Horton

Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, David Fetter <david@fetter.org>, pgsql-hackers@postgresql.org
Date: 2018-10-26T04:52:34Z
Lists: pgsql-hackers 
On Fri, Oct 26, 2018 at 09:31:48AM +0900, Michael Paquier wrote:
> Committed 0001 now which adds tab completion for CREATE TRIGGER.
> Something you missed is that we should still be able to complete with
> PROCEDURE or FUNCTION (depending on the backend version) if CREATE
> TRIGGER .. EXECUTE is present on screen.  The priority is given to
> complete with both EXECUTE PROCEDURE and EXECUTE FUNCTION at the same
> time, but you also should have the intermediate state.  I also added
> some brackets for clarity, and a comment about the grammar selection.

And 0002 is committed as well.  Thanks for the patches! 
--
Michael

Commits

  1. Add tab completion of EXECUTE FUNCTION for CREATE TRIGGER in psql

  2. Improve tab completion of CREATE EVENT TRIGGER in psql

  3. Improve tab completion for ANALYZE, EXPLAIN, and VACUUM.