Re: Function to promote standby servers
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Ian Barwick <ian@2ndquadrant.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>, Masahiko Sawada <sawada.mshk@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-10-26T04:51:24Z
Lists: pgsql-hackers
On Fri, Oct 26, 2018 at 11:36:00AM +0900, Ian Barwick wrote: > Documentation for this [*] says "Returns true if promotion is > successful and false otherwise", which is not correct if "wait" is > false, as it will always return TRUE. Yes, in the case where the promotion has been initiated. > + <literal>false</literal> otherwise. If <parameter>wait</parameter> > + is set to <literal>false</literal>, the function returns <literal>true</literal> > + immediately after sending the promotion signal to the postmaster. Or we could use "the function returns true immediately after initiating the promotion by sending the promotion signal to the postmaster"? As a native speaker which one feels more natural to you? -- Michael
Commits
-
Rework documentation of pg_promote
- 74171f8c12e6 12.0 landed
-
Add pg_promote function
- 10074651e335 12.0 landed