Horton

Re: pgsql: Add TAP tests for pg_verify_checksums

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Stephen Frost <sfrost@snowman.net>
Cc: Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, Daniel Gustafsson <daniel@yesql.se>, Magnus Hagander <magnus@hagander.net>, Michael Banck <michael.banck@credativ.de>, Postgres hackers <pgsql-hackers@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2018-10-20T06:51:26Z
Lists: pgsql-hackers 
On Sat, Oct 20, 2018 at 02:03:32AM -0400, Stephen Frost wrote:
> On Sat, Oct 20, 2018 at 01:11 Andres Freund <andres@anarazel.de> wrote:
>> or the new checksum validation logic complaining about them, and such
>>> when doing backups and I wonder if that is because people simply don’t
>>> use the two together much, making me wonder how much of an issue this
>>> really is or would be with the account-for-everything approach I’ve
>>> been advocating for.
>>
>> I mean obviously pg_verify_checksum simply hasn't been actually tested
>> much with plain postgres without extensions, given the all weaknesses
>> identified in this thread.
> 
> No, it hasn’t, but pg_basebackup has been around quite a while and has
> always copied everything, as best as I can recall anyway.

At this point, let's create a new thread with a description of what has
been discussed and what we'd like to do for HEAD and v11.  I got
something in mind which would result in a minimal patch.  Let's start
from that.
--
Michael

Commits

  1. Fix issues with TAP tests of pg_verify_checksums

  2. Use whitelist to choose files scanned with pg_verify_checksums

  3. Add TAP tests for pg_verify_checksums

  4. Work around Msys weakness in Testlib.pm's command_like()