Re: pgsql: Add TAP tests for pg_verify_checksums
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: J Chapman Flack <jflack@math.purdue.edu>
Cc: Stephen Frost <sfrost@snowman.net>, Michael Paquier <michael@paquier.xyz>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, Michael Banck <michael.banck@credativ.de>, Postgres hackers <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Magnus Hagander <magnus@hagander.net>
Date: 2018-10-19T18:21:27Z
Lists: pgsql-hackers
On 2018-10-19 14:08:19 -0400, J Chapman Flack wrote: > On 10/19/2018 01:17 PM, Andres Freund wrote: > > On 2018-10-19 10:36:59 -0400, Stephen Frost wrote: > > > >> I also categorically disagree with the notion that it's ok for > >> extensions to dump files into our tablespace diretories .... > > > > I'm unconvinced. There already are extensions doing so, and it's not > > like we've given them any sort of reasonable alternative. You can't just > > create relations in a "registered" / "supported" kinda way right now, so > > uh, yea, extension gotta make do. And that has worked for many years. > > For some of us following along at home, this got interesting right here. > Could someone elaborate on what extensions do this, for what purpose? > And what would it mean to create relations in a "registered" / > "supported" kinda way? Has that been the topic of a past discussion > I could catch up with? An fdw, like cstore, might be doing it, to store data, for example. The registered / supported thing would be to have a catalog representation of on-disk files that is represented in the catalogs somewhow. Right now you can't really do that because you need a proper relation (table, index, ...) to get a relfilenode. Greetings, Andres Freund
Commits
-
Fix issues with TAP tests of pg_verify_checksums
- 9685d7383ab4 12.0 landed
-
Use whitelist to choose files scanned with pg_verify_checksums
- cc7f27eae888 11.1 landed
- d55241af7056 12.0 landed
-
Add TAP tests for pg_verify_checksums
- b34e84f160a4 12.0 cited
-
Work around Msys weakness in Testlib.pm's command_like()
- efd7f8e36553 10.0 cited