Re: pgsql: Add TAP tests for pg_verify_checksums

Hi,

On Fri, Oct 12, 2018 at 03:05:43PM +0900, Michael Paquier wrote:
> On Fri, Oct 12, 2018 at 12:11:58PM +0900, Michael Paquier wrote:
> > Agreed.  I am just working on a patch for v11- which uses a
> > whitelist-based method instead of what is present now.  Reverting the
> > tests to put the buildfarm to green could be done, but that's not the
> > root of the problem.

I think that's the right solution; the online verification patch adds
even more logic to the blacklist so getting rid of it in favor of a
whitelist is +1 with me.
 
> So, I have coded this thing, and finish with the attached.  The
> following file patterns are accepted for the checksums:
> <digits>.<segment>
> <digits>_<forkname>
> <digits>_<forkname>.<segment>
> I have added some tests on the way to make sure that all the patterns
> get covered.  Please note that this skips the temporary files.

Maybe also add some correct (to be scanned) but non-empty garbage files
later on that it should barf on?


Michael

-- 
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax:  +49 2166 9901-100
Email: michael.banck@credativ.de

credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer

Unser Umgang mit personenbezogenen Daten unterliegt
folgenden Bestimmungen: https://www.credativ.de/datenschutz