Horton

Re: pgsql: Add TAP tests for pg_verify_checksums

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Magnus Hagander <magnus@hagander.net>
Date: 2018-10-12T06:05:43Z
Lists: pgsql-hackers

Attachments

On Fri, Oct 12, 2018 at 12:11:58PM +0900, Michael Paquier wrote:
> Agreed.  I am just working on a patch for v11- which uses a
> whitelist-based method instead of what is present now.  Reverting the
> tests to put the buildfarm to green could be done, but that's not the
> root of the problem.

So, I have coded this thing, and finish with the attached.  The
following file patterns are accepted for the checksums:
<digits>.<segment>
<digits>_<forkname>
<digits>_<forkname>.<segment>
I have added some tests on the way to make sure that all the patterns
get covered.  Please note that this skips the temporary files.

Thoughts?
--
Michael

Commits

  1. Fix issues with TAP tests of pg_verify_checksums

  2. Use whitelist to choose files scanned with pg_verify_checksums

  3. Add TAP tests for pg_verify_checksums

  4. Work around Msys weakness in Testlib.pm's command_like()