Horton

Re: pgsql: Add TAP tests for pg_verify_checksums

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Magnus Hagander <magnus@hagander.net>
Date: 2018-10-12T03:11:58Z
Lists: pgsql-hackers 
On Thu, Oct 11, 2018 at 07:41:18PM -0700, Andres Freund wrote:
> We only remove temp dirs on startup, and I'm pretty sure there at least
> not too long ago were a few error cases where we can leak temp files in
> individual sessions.  And there's talk about allowing
> pg_verify_checksums when online.  So this seems to be an angle that
> needs to be thought about...

Agreed.  I am just working on a patch for v11- which uses a
whitelist-based method instead of what is present now.  Reverting the
tests to put the buildfarm to green could be done, but that's not the
root of the problem.
--
Michael

Commits

  1. Fix issues with TAP tests of pg_verify_checksums

  2. Use whitelist to choose files scanned with pg_verify_checksums

  3. Add TAP tests for pg_verify_checksums

  4. Work around Msys weakness in Testlib.pm's command_like()