Horton

Re: pgsql: Add TAP tests for pg_verify_checksums

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Magnus Hagander <magnus@hagander.net>
Date: 2018-10-12T01:39:18Z
Lists: pgsql-hackers

Attachments

On Thu, Oct 11, 2018 at 06:04:11PM -0700, Andres Freund wrote:
> culicidae tests EXEC_BACKEND, so there's an explanation as to why it
> sometimes behaves differently. But here I don't immediately see how
> that'd matter. Probably still worth verifying that it's not somehow
> caused by that.

Thanks, that's the point of detail I needed about culicidae (you will
need to explain me one day face-to-face how you pronounce it).  I have
been able to reproduce the problem, and that's a bug within
pg_verify_checksums as it fails to consider that config_exec_params is
not a file it should scan when using EXEC_BACKEND.  The same can happen
with config_exec_params.new.

The attached, which fixes the issue for me, needs to be back-patched to
v11.
--
Michael

Commits

  1. Fix issues with TAP tests of pg_verify_checksums

  2. Use whitelist to choose files scanned with pg_verify_checksums

  3. Add TAP tests for pg_verify_checksums

  4. Work around Msys weakness in Testlib.pm's command_like()