Re: Make Windows print float exponents like everybody else?
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2018-10-09T22:05:39Z
Lists: pgsql-hackers
Hi, On 2018-10-09 18:00:54 -0400, Tom Lane wrote: > I can't believe I got no comments about this, so reposting it under > a more attention-getting title ... > > In https://www.postgresql.org/message-id/29037.1539021687@sss.pgh.pa.us > I wrote: > > > Also, we have quite a few variant expected-files that exist only to cater > > for Windows' habit of printing three exponent digits where everybody else > > prints just two. It struck me that it would not be hard, or expensive, > > to undo that choice in snprintf.c (see attached untested patch). So we > > could considerably reduce future maintenance pain for the affected tests > > by getting rid of those files. > > > > As against that, Windows users might possibly complain that float output > > looks different than they're used to. I'm not sure how much sympathy > > I have for that position. If we reimplement float output for more speed, > > as is under discussion in nearby threads, I doubt we'd trouble to preserve > > this Windows-ism in the rewrite. > > > > Comments? No pushback here. Lower likelihood of turning the buildfarm red, lower likelihood of being embarrased. Good. ;) Greetings, Andres Freund
Commits
-
Another round of portability hacking on ECPG regression tests.
- 240cd6bc8366 12.0 landed
-
Make float exponent output on Windows look the same as elsewhere.
- f1885386f624 12.0 landed