Horton

Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgreSQL.org
Date: 2018-10-09T21:37:09Z
Lists: pgsql-hackers 
Hi,

On 2018-10-09 17:27:17 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > As discussed below (at [1]), I think we should remove $subject.  I plan
> > to do so, unless somebody protests soon-ish.  I thought it'd be better
> > to call attention to this in a new thread, to make sure people had a
> > chance to object.
> 
> I complained about this already on the other thread, I think, but:
> I do not think we should remove timeofday().  It's unrelated to these
> datatypes and it offers functionality that isn't quite duplicated
> elsewhere.

Ok.  I find it a somewhat weird function, but I agree it's not strongly
related. It only came up because it's implemented in nabstime.c.  Moving
it to utils/adt/timestamp.c seems to make the most sense?

Greetings,

Andres Freund

Commits

  1. Clean up/tighten up coercibility checks in opr_sanity regression test.

  2. Remove abstime, reltime, tinterval tables from old regression databases.