Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: David Fetter <david@fetter.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgreSQL.org
Date: 2018-10-09T19:31:19Z
Lists: pgsql-hackers
Hi, On 2018-10-09 21:26:31 +0200, David Fetter wrote: > On Tue, Oct 09, 2018 at 12:22:37PM -0700, Andres Freund wrote: > > In-Reply-To: <20180928223240.kgwc4czzzekrpsid@alap3.anarazel.de> > > As discussed below (at [1]), I think we should remove $subject. I plan > > to do so, unless somebody protests soon-ish. I thought it'd be better > > to call attention to this in a new thread, to make sure people had a > > chance to object. > > How much time would someone have to convert the timetravel piece of > contrib/spi to use non-deprecated time types in order to make this > window? "this window"? It's not entirely trivial, but also not that hard. It'd break existing users however, as obviously their tables wouldn't dump / load or pg_upgrade into a working state. But I think spi/timetravel is not something people can actually use / do use much, the functionality is way too limited in practice, the datatypes have been arcane for about as long as postgres existed, etc. And the code isn't fit to serve as an example. In my opinion it has negative value at this point. Greetings, Andres Freund
Commits
-
Clean up/tighten up coercibility checks in opr_sanity regression test.
- e9f42d529f99 12.0 landed
-
Remove abstime, reltime, tinterval tables from old regression databases.
- fb583c80d230 9.3.25 landed
- 7b88c1ddd049 9.4.20 landed
- 9320263ae7ca 10.6 landed
- 43cc4e49edff 9.5.15 landed
- 2ad422ce10a4 9.6.11 landed
- 184951a48a10 11.0 landed