[HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgreSQL.org
Date: 2018-10-09T19:22:37Z
Lists: pgsql-hackers
In-Reply-To: <20180928223240.kgwc4czzzekrpsid@alap3.anarazel.de> Hi, As discussed below (at [1]), I think we should remove $subject. I plan to do so, unless somebody protests soon-ish. I thought it'd be better to call attention to this in a new thread, to make sure people had a chance to object. Regards, Andres In "Something for the TODO list: deprecating abstime and friends" On 2018-09-28 15:32:40 -0700, Andres Freund wrote: > On 2017-12-13 00:05:06 -0800, Andres Freund wrote: > > > * contrib/spi/timetravel depends on abstime columns to represent what > > > would nowadays be better done as a tstzrange. I'd have thought we > > > could maybe toss that example module overboard, but we just today got > > > a question about its usage, so I'm afraid it's not quite dead yet. > > > What shall we do with that? > > > > Looking at the code I'd be pretty strongly inclined to scrap it. > > > > > > Before I'd discovered this thread, I'd started to write up a > > patch. Attached. It's clearly not fully done. Questions I'd while > > hacking things up: > > - what to do with contrib/spi/timetravel - I'd just removed it from the > > relevant Makefile for now. > > - nabstime.c currently implements timeofday() which imo is a pretty > > weird function. I'd be quite inclined to remove it at the same time as > > this. > > Here's a refreshed version of this patch. First patch removes > contrib/spi/timetravel, second patch removes abstime, reltime, tinterval > together with timeofday(). > > I think we should just go ahead and commit something like this soon. [1] http://archives.postgresql.org/message-id/20180928223240.kgwc4czzzekrpsid%40alap3.anarazel.de
Commits
-
Clean up/tighten up coercibility checks in opr_sanity regression test.
- e9f42d529f99 12.0 landed
-
Remove abstime, reltime, tinterval tables from old regression databases.
- fb583c80d230 9.3.25 landed
- 7b88c1ddd049 9.4.20 landed
- 9320263ae7ca 10.6 landed
- 43cc4e49edff 9.5.15 landed
- 2ad422ce10a4 9.6.11 landed
- 184951a48a10 11.0 landed