Horton

Re: PATCH: Configurable file mode mask

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Michael Paquier <michael.paquier@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Stephen Frost <sfrost@snowman.net>, Adam Brightwell <adam.brightwell@crunchydata.com>, Robert Haas <robertmhaas@gmail.com>, "Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>, Tom Lane <tgl@sss.pgh.pa.us>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-03-26T07:22:42Z
Lists: pgsql-hackers 
On Fri, Mar 23, 2018 at 12:26:47PM -0400, David Steele wrote:
> I've attached a patch that integrates my tests with the current tests.
> If you don't think they are worth adding then I'll just drop them from
> my patchset.

It seems to me that those tests have values (we can add more tests for
transaction ID and such in the future), but I would recommend to put
them in a separate file named like t/003_reset.pl for tests which
execute resets and checks their consistency on the cluster.
--
Michael

Commits

  1. Allow group access on PGDATA

  2. Refactor dir/file permissions

  3. Revert "Add basic TAP test setup for pg_upgrade"

  4. Add basic TAP test setup for pg_upgrade