Re: Undesirable entries in typedefs list
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2018-03-24T17:29:19Z
Lists: pgsql-hackers
Hi, On 2018-03-24 13:25:34 -0400, Tom Lane wrote: > (2) "abs", "boolean", "iterator", "other", "pointer", "reference", > "string", and "type" all now are listed as typedef names. > > It's probably okay to treat "boolean" as a typedef, but all those others > are complete disasters. Anyone know where they're coming from? Semi informed theory: LLVM? I think I'd configured one of the LLVM animals to collect typedefs, but that might have been a bad idea... > As for "bool", we could probably deal with that most reliably by > having pgindent add it as a special case. Maybe we could get it > back in there by having some trailing-edge buildfarm member > contribute typedefs, but that seems like a solution with a rather > limited half-life. Could we combine the list of typedefs with one manually maintained in-tree? Greetings, Andres Freund
Commits
-
Update pgindent's typedefs blacklist, and make it easier to adjust.
- ef1978d6ed1e 11.0 landed