Horton

Re: [HACKERS] taking stdbool.h into use

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>, Michael Paquier <michael.paquier@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-hackers <pgsql-hackers@postgresql.org>, Thomas Munro <thomas.munro@enterprisedb.com>
Date: 2018-03-20T21:14:23Z
Lists: pgsql-hackers 
Hi,

On 2018-03-20 17:04:22 -0400, Peter Eisentraut wrote:
> On 3/20/18 02:18, Tom Lane wrote:
> > I think it'd be worth identifying exactly which platforms have
> > sizeof(bool) different from 1.  Are any of them things that anyone
> > cares about going forward?  The point of this patch is to ease
> > future development of extensions, but it's unlikely any extension
> > authors care about portability onto, say, macOS 10.4 (prairiedog).
> 
> I'm not sure I follow.  Say we commit configure tests and discover that
> platforms A, B, and C are affected.  What would we do with that
> information?  I don't think we are saying we'd just break A, B, and C.

If those are only older platforms we could just not use stdbool for
those. The likelihood of getting into conflicts with $library stdbool
uses is lower...

Greetings,

Andres Freund

Commits

  1. Use stdbool.h if suitable

  2. Add configure tests for stdbool.h and sizeof bool

  3. Remove useless use of bit-masking macros

  4. Change various Gin*Is* macros to return 0/1.

  5. Fix several possibly non-portable gaffs in record_image_ops.