Re: [PATCH] Verify Checksums during Basebackups
Michael Banck <michael.banck@credativ.de>
From: Michael Banck <michael.banck@credativ.de>
To: pgsql-hackers@lists.postgresql.org
Cc: David Steele <david@pgmasters.net>, Stephen Frost <sfrost@snowman.net>, Magnus Hagander <magnus@hagander.net>, Robert Haas <robertmhaas@gmail.com>
Date: 2018-03-17T21:34:35Z
Lists: pgsql-hackers
Attachments
- basebackup-verify-checksum-V3.patch (text/x-diff) patch
Hi, On Fri, Mar 09, 2018 at 10:35:33PM +0100, Michael Banck wrote: > Possibly open questions: > > 1. I have not so far changed the replication protocol to make verifying > checksums optional. I can go about that next if the consensus is that we > need such an option (and cannot just check it everytime)? I think most people (including those I had off-list discussions about this with) were of the opinion that such an option should be there, so I added an additional option NOVERIFY_CHECKSUMS to the BASE_BACKUP replication command and also an option -k / --no-verify-checksums to pg_basebackup to trigger this. Updated patch attached. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.banck@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
Commits
-
Validate page level checksums in base backups
- 4eb77d50c21d 11.0 landed