Re: ExplainProperty* and units

Hi,

On 2018-03-14 14:34:38 +1300, David Rowley wrote:
> On 14 March 2018 at 13:27, Andres Freund <andres@anarazel.de> wrote:
> > In the attached *POC* patch I've added a 'unit' parameter to the numeric
> > ExplainProperty* functions, which EXPLAIN_FORMAT_TEXT adds to the
> > output.  This can avoid the above and other similar branches (of which
> > the JIT patch would add a number).
> 
> > Comments?
> 
> This seems like a good change.

Cool.


> It would be nice to see us completely get rid of all the
> appendStringInfo* calls, apart from in the functions which meant to
> handle the behaviour specific to the explain format. This is a step
> towards that, so has my vote.

Do you mean you want to only use ExplainProperty*? Given the desire of
density for plan output that seem hard to achieve.


> Functions like show_hash_info are making it difficult to do more in this area.

Hm, what's the problem?

Greetings,

Andres Freund