Re: Failed to request an autovacuum work-item in silence
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-03-08T13:46:56Z
Lists: pgsql-hackers
Hi I was thinking that the BRIN code requesting the workitem would print the error message based on the return value. There is no point to returning a boolean indicator if the caller isn't going to do anything with it ... This means you don't need to convert the type to string in autovacuum.c (which would defeat attempts at generalizing this code). -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Log when a BRIN autosummarization request fails
- eadcb7a2377a 10.4 landed
- 484a4a08abe3 11.0 landed