Re: Change RangeVarGetRelidExtended() to take flags argument?
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Date: 2018-03-06T01:17:49Z
Lists: pgsql-hackers
On Mon, Mar 05, 2018 at 05:06:59PM -0800, Andres Freund wrote: > Yea, that's a concern. OTOH, it doesn't seem nice to grow duplicates of > similar code. It'd not be too hard to move RangeVarGetRelidExtended() > code into RangeVarGetRelidInternal() and add > RangeVarGetRelidTryLock(). Not sure if that's any better. Or just add > RangeVarGetRelidExtended2() :) FWIW, it would have been nice to switch RangeVarGetRelidExtended so as it handles a set of uint8 flags as one of its arguments. missing_ok and nowait could be part of that. Avoiding a new flavor of RangevarGet would be also nice, now RangeVarGetRelidExtended() is likely popular enough in extensions that much things would break. -- Michael
Commits
-
Add SKIP_LOCKED option to RangeVarGetRelidExtended().
- 3e256e550672 11.0 landed
-
Combine options for RangeVarGetRelidExtended() into a flags argument.
- d87510a524f3 11.0 landed