Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)?
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, Tels <nospam-pg-abuse@bloodgate.com>, Stephen Froehlich <s.froehlich@cablelabs.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-03-05T17:25:39Z
Lists: pgsql-hackers, pgsql-novice
David G. Johnston wrote: > This bug has an obvious if annoying work-around and fixing the bug will > likely cause people's code, that uses said work-around, to fail. Breaking > people's working code in stable release branches is generally a no-no. > > However, given that this was discovered 4 months after the feature was > released suggests to me that we are justified, and community-serving, to > back-patch this. Put more bluntly, we can ask for more leeway in the first > few patch releases of a new feature since more people will benefit from 5 > years of a fully-baked feature than may be harmed by said change. We > shouldn't abuse that but an obvious new feature bug/oversight like this > seems reasonable. I agree with this argumentation and in my opinion we should back-patch this as a bugfix. Certainly if I had remembered about CREATE TABLE LIKE I would have stalled the ext.stats patch. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Clone extended stats in CREATE TABLE (LIKE INCLUDING ALL)
- 911e6236bab5 10.4 landed
- 5564c1181548 11.0 landed
-
Identity columns
- 321732705363 10.0 cited