Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>

To: Tomas Vondra <tomas.vondra@2ndquadrant.com>

Cc: David Steele <david@pgmasters.net>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2018-03-03T01:36:10Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Tighten the concurrent abort check during decoding.
- 2ce353fc1902 14.0 landed
Improve hash_create()'s API for some added robustness.
- b3817f5f7746 14.0 landed
Use HASH_BLOBS for xidhash.
- a1b8aa1e4eec 14.0 landed
Fix initialization of RelationSyncEntry for streaming transactions.
- 69bd60672af6 14.0 landed
Remove unused function declaration in logicalproto.h.
- ddd5f6d2609b 14.0 landed
Add additional tests to test streaming of in-progress transactions.
- 58b5ae9d62bd 14.0 landed
Fix inline marking introduced in commit 464824323e.
- ac15b499f7f9 14.0 landed
Add support for streaming to built-in logical replication.
- 464824323e57 14.0 landed
Fix the SharedFileSetUnregister API.
- 4ab77697f67a 14.0 landed
Fix comment in procarray.c
- 77c7267c37f7 14.0 cited
Suppress compiler warning in non-cassert builds.
- e942af7b8261 14.0 cited
Extend the BufFile interface.
- 808e13b282ef 14.0 landed
Mark a few logical decoding related variables with PGDLLIMPORT.
- b48cac3b10a0 14.0 landed
Implement streaming mode in ReorderBuffer.
- 7259736a6e5b 14.0 landed
Extend the logical decoding output plugin API with stream methods.
- 45fdc9738b36 14.0 landed
WAL Log invalidations at command end with wal_level=logical.
- c55040ccd017 14.0 landed
Immediately WAL-log subtransaction and top-level XID association.
- 0bead9af484c 14.0 landed
Allow logical replication to transfer data in binary format.
- 9de77b545313 14.0 cited
Only superuser can set sslcert/sslkey in postgres_fdw user mappings
- cebf9d6e6ee1 13.0 cited
Track statistics for spilling of changes from ReorderBuffer.
- 9290ad198b15 13.0 landed
Add logical_decoding_work_mem to limit ReorderBuffer memory usage.
- cec2edfa7859 13.0 landed
logical decoding: process ASSIGNMENT during snapshot build
- bac2fae05c77 13.0 cited
Emit invalidations to standby for transactions without xid.
- c6ff84b06a68 9.6.0 cited

On 2018-03-03 02:34:06 +0100, Tomas Vondra wrote:
> On 03/03/2018 02:01 AM, Andres Freund wrote:
> > On 2018-03-03 02:00:46 +0100, Tomas Vondra wrote:
> >> That is somewhat misleading, I think. You're right the last version
> >> was submitted on 2018-01-19, but the next review arrived on
> >> 2018-01-31, i.e. right at the end of the CF. So it's not like the
> >> patch was sitting there with unresolved issues. Based on that
> >> review the patch was marked as RWF and thus not moved to 2018-03
> >> automatically.
> > 
> > I don't see how this changes anything.
> > 
> 
> You've used "The patch hasn't moved forward since 2018-01-19," as an
> argument why the patch is not eligible for 2018-03. I suggest that
> argument is misleading, because patches generally do not move without
> reviews, and it's difficult to respond to a review that arrives on the
> last day of a commitfest.
> 
> Consider that without the review, the patch would end up with NR status,
> and would be moved to the next CF automatically. Isn't that a bit weird?

Not sure I follow. The point is that nobody would have complained if
you'd moved the patch into this fest if you'd updated it *before* it
started?

Greetings,

Andres Freund