Re: Online enabling of checksums
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Magnus Hagander <magnus@hagander.net>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Michael Banck <michael.banck@credativ.de>
Date: 2018-03-02T14:17:36Z
Lists: pgsql-hackers
Magnus Hagander wrote: > On Wed, Feb 28, 2018 at 10:07 PM, Tomas Vondra <tomas.vondra@2ndquadrant.com > > I'd argue this is merely a mistake in the --help text. Firstly, > > relfilenodes are OIDs too, so I don't think "-o" is incorrect. Secondly, > > the SGML docs actually say: > Yeah, that one is my fault. It used to say oid all over but I noticed and > fixed it. Except I clearly missed the --help. Obviously option names are completely arbitrary -- you could say "-P relfilenode" and it'd still be 'correct', since it works as documented. But we try to make these options mnemotechnic when we can, and I don't see any relation between "-o" and "relfilenode", so I suggest picking some other letter. There's a whole alphabet out there. Either "-r" or "-f" works better for me than "-o". -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Online enabling and disabling of data checksums
- f19c0eccae96 19 (unreleased) landed
-
Deactive flapping checksum isolation tests.
- bf75fe47e444 11.0 landed
-
Add support for coordinating record typmods among parallel workers.
- cc5f81366c36 11.0 cited