Horton

Re: PATCH: Configurable file mode mask

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: David Steele <david@pgmasters.net>
Cc: Michael Paquier <michael.paquier@gmail.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Stephen Frost <sfrost@snowman.net>, Adam Brightwell <adam.brightwell@crunchydata.com>, Robert Haas <robertmhaas@gmail.com>, "Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>, Tom Lane <tgl@sss.pgh.pa.us>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-03-02T02:04:41Z
Lists: pgsql-hackers 
Hi,

On 2018-02-27 15:52:32 -0500, David Steele wrote:
> Thanks for having a look at the patches.

I'd personally appreciate if you'd add commit messages to the individual
patches in a series. A brief explanation why something is done is good
enough.  E.g. here it's far from obvious why something is done with
pg_resetwal.

I'd suggest just using git format-patch -v to format series.


Independent of that, I'm not entirely clear on what the status of this
patch is, without rereading the thread. Could you summarize?

- Andres

Commits

  1. Allow group access on PGDATA

  2. Refactor dir/file permissions

  3. Revert "Add basic TAP test setup for pg_upgrade"

  4. Add basic TAP test setup for pg_upgrade