Horton

Re: Sigh, I broke crake again

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@lists.postgresql.org
Date: 2018-02-27T18:42:19Z
Lists: pgsql-hackers 
Hi,

On 2018-02-27 13:36:59 -0500, Tom Lane wrote:
> I just committed some regression test cleanup that removed or renamed
> a couple of C-language functions in regress.so.  I see that crake is
> now failing XversionUpgrade tests, and although I can't see the details,
> I bet the problem is from trying to load CREATE FUNCTION commands from
> the old regression databases that now don't point to an existing C
> function.
> 
> Does it seem practical to adjust TestUpgradeXversion.pm to cope with
> this change?  An alternative answer is to put back C-language stubs
> in regress.c for the removed functions, but that seems a bit grotty.

Could we just drop the relevant functions in the course of the test?

Greetings,

Andres Freund

Commits

  1. Revert renaming of int44in/int44out.

  2. Remove regression tests' CREATE FUNCTION commands for unused C functions.