Horton

Re: CURRENT OF causes an error when IndexOnlyScan is used

Aleksander Alekseev <a.alekseev@postgrespro.ru>

View thread View on postgr.es
From: Aleksander Alekseev <a.alekseev@postgrespro.ru>
To: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Yugo Nagata <nagata@sraoss.co.jp>, pgsql-hackers@postgresql.org
Date: 2018-02-20T09:52:53Z
Lists: pgsql-hackers 
Hi Anastasia,

> I'd like to propose the patch that fixes the issue.
> We already have a way to return heaptuple from IndexOnlyScan,
> but it was not applied to b-tree for some reason.
> 
> Attached patch solves the reported bug.
> Moreover, it will come in handy for "index with included attributes" feature
> [1],
> where we can store long (and even TOASTed) attributes in indextuple.
> 
> [1] https://commitfest.postgresql.org/17/1350/

I believe the patch should include a test that tries to reproduce an
issue it tries to fix.

Also maybe this code that repeats 3 times can be moved to a separate
procedure?

-- 
Best regards,
Aleksander Alekseev

Commits

  1. Fix WHERE CURRENT OF when the referenced cursor uses an index-only scan.