Horton

Re: CALL stmt, ERROR: unrecognized node type: 113 bug

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2018-02-14T04:42:08Z
Lists: pgsql-hackers 
On Tue, Feb 13, 2018 at 03:26:20PM -0500, Peter Eisentraut wrote:
> and committed

Thanks, those changes are fine for me.

Perhaps you want to have print_function_rettype() drop a elog(ERROR) if
called with an invalid prorettype?  I tend to be allergic to Asserts
in ruleutils.c since 0daeba0e...
--
Michael

Commits

  1. Avoid premature free of pass-by-reference CALL arguments.

  2. Fix oversight in CALL argument handling, and do some minor cleanup.