Horton

Re: CALL stmt, ERROR: unrecognized node type: 113 bug

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, "David G. Johnston" <david.g.johnston@gmail.com>, Pavel Stehule <pavel.stehule@gmail.com>, Postgres hackers <pgsql-hackers@postgresql.org>, Andrew Dunstan <andrew@dunslane.net>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Date: 2018-02-10T12:33:00Z
Lists: pgsql-hackers 
On Fri, Feb 09, 2018 at 08:30:49AM -0800, Andres Freund wrote:
> On 2018-02-09 09:42:41 -0500, Tom Lane wrote:
>> It doesn't look significantly different to me than the restriction
>> that you can't have sub-selects in CHECK expressions, index
>> expressions, etc.  Obviously we need a clean failure like you get for
>> those cases.  But otherwise it's an OK restriction that stems from
>> exactly the same cause: we do not want to invoke the full planner in
>> this context (and even if we did, we don't want to use the full
>> executor to execute the result).
> 
> +1

+1.
--
Michael

Commits

  1. Avoid premature free of pass-by-reference CALL arguments.

  2. Fix oversight in CALL argument handling, and do some minor cleanup.